INSANE bugs #1463
Merged
INSANE bugs #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is still failing to find a root reference which, for example, YourKit displays: I checked that implementing this TODO did not help, because diff --git a/harness/o.n.insane/src/org/netbeans/insane/impl/InsaneEngine.java b/harness/o.n.insane/src/org/netbeans/insane/impl/InsaneEngine.java
index e1a1b5b1ac..f47fbf1586 100644
--- a/harness/o.n.insane/src/org/netbeans/insane/impl/InsaneEngine.java
+++ b/harness/o.n.insane/src/org/netbeans/insane/impl/InsaneEngine.java
@@ -190,7 +190,12 @@ try {
//if (cls.getName().startsWith("org.netbeans.insane.scanner")) return; // skip refs from myself
ClassLoader cl = cls.getClassLoader();
- if ( cl != null) recognize(cl);
+ if (cl != null) {
+ if (filter.accept(cl, cls, null)) {
+ recognize(cl);
+ if (objects.isKnown(cl)) visitor.visitObjectReference(objects, cls, cl, /* cannot get a Field for Class.classLoader */ null);
+ }
+ }
// process only fields declared by this class,
// fields of all superclasses were already processed in separate run.
diff --git a/harness/o.n.insane/src/org/netbeans/insane/scanner/SimpleXmlVisitor.java b/harness/o.n.insane/src/org/netbeans/insane/scanner/SimpleXmlVisitor.java
index 2f48f271d4..cea5a72f45 100644
--- a/harness/o.n.insane/src/org/netbeans/insane/scanner/SimpleXmlVisitor.java
+++ b/harness/o.n.insane/src/org/netbeans/insane/scanner/SimpleXmlVisitor.java
@@ -120,7 +120,7 @@ public final class SimpleXmlVisitor implements Visitor {
}
private static String getFldName(Field fld) {
- return fld.getDeclaringClass().getName() + "." + fld.getName();
+ return fld == null ? "?" : fld.getDeclaringClass().getName() + "." + fld.getName();
}
So not sure why INSANE fails in this case. |
YTN01
approved these changes
Aug 28, 2019
|
The changes are sane, I'm going to merge them. |
|
@lkishalmi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things that I bumped into while investigating jenkinsci/bom#77. I actually have a laundry list of INSANE issues to fix, but one thing at a time.